Dockerfile changes to build gvforwarder #460
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: vyasgun The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
vyasgun
force-pushed
the
pr/gvforwarder-build
branch
from
e78f584 to
18fa67b
Compare
images/Dockerfile
Outdated
| WORKDIR $APP_ROOT/src | ||
| COPY . . | ||
| RUN make | ||
| FROM registry.access.redhat.com/ubi9/go-toolset:1.22.9 AS build |
There was a problem hiding this comment.
I would have expected that changing this line FROM registry.access.redhat.com/ubi9/go-toolset:1.22.9 AS build is enough to fix make image?
I'd use latest rather than a hardcoded version so that we don't need to update it too often.
There was a problem hiding this comment.
I was running into errors while running the script so I put the fixes.
Changed the tag to latest
There was a problem hiding this comment.
If I understand correctly, your changes allow to build from the images directory, eg cd images; podman build .
make image on the other hand attempts to build from the top level directory, not from images.
With your changes, this no longer works.
I'm fine with building from images as long as make image is updated and still works. It would be worth adding a check in github actions that the image can always be built, this does not seem to be tested at the moment.
There was a problem hiding this comment.
yes, you're right - thanks! I changed the Dockerfile.
It would be worth adding a check in github actions that the image can always be built, this does not seem to be tested at the moment.
Something like this? (adding a target in the existing build check) or would it be better to have a separate check?
vyasgun
force-pushed
the
pr/gvforwarder-build
branch
from
18fa67b to
409b6c5
Compare
Signed-off-by: Gunjan Vyas <[email protected]>
vyasgun
force-pushed
the
pr/gvforwarder-build
branch
3 times, most recently
from
627f949 to
421fe7b
Compare
Signed-off-by: Gunjan Vyas <[email protected]>
vyasgun
force-pushed
the
pr/gvforwarder-build
branch
from
421fe7b to
3dc6f02
Compare
Fixes: https://github.com/crc-org/crc-internal/issues/93